liblzma and MSVC

[schnaader]

In a Precomp branch on Github, I added on-the-fly compression/decompression using liblzma. Using MinGW, everything compiles fine after some minor adjustments. Then I tried to update the MSVC solution (with this commit). I had to use an inttypes.h replacement and even after that, there are thousands of errors. It seems there is some problem using the "inline" keyword in C in MSVC. Usually, this should be fixed using "__inline" instead, which liblzma does (in sysdefs.h):

// As of MSVC 2013, inline and restrict are supported with
// non-standard keywords.
#if defined(_WIN32) && defined(_MSC_VER)
#	ifndef inline
#		define inline __inline
#	endif
#	ifndef restrict
#		define restrict __restrict
#	endif
#endif

But sadly, neither this nor commenting the above code works, both lead to many errors in or around inlined functions. I'm using MSVC 2012, perhaps this is better in MSVC 2013/2015, could anyone check?

Any help or hints would be appreciated. As maintaing the MSVC solution gets more and more cumbersome with things like this, I think about supporting only MinGW on Windows and removing the Visual Studio project.

[nemequ]

We build liblzma as part of Squash with VS 12 (2013) and 14 (2015), it works. That said, __inline has been around since at least VS 6, and __restrict since VS 2005. Are you sure they are what is causing the errors?

[PrinceGupta]

any news about difflate

sorry,for the off topic question

[schnaader]

It's Visual Studio 2012 that doesn't work with liblzma because it lacks C99 support. It's even in the XZ utils documentation, as sftt (the Precomp branch author) pointed out - from windows\INSTALL-MSVC.txt:

MSVC 2013 update 2 and later have enough C99 support to build
liblzma from XZ Utils 5.2.0 and later without modifications.
Older MSVC versions would require a large number of changes to
the XZ Utils code and thus the old MSVC versions aren't supported.

---

any news about difflate

I'm working on it, adjusting, cleaning and documenting the code so I can push an usable initial commit.